From e5c0eae62283224cf980f13ff3f5d3cf14eafe80 Mon Sep 17 00:00:00 2001 From: Brian Rogers Date: Thu, 1 Sep 2022 12:49:25 -0600 Subject: [PATCH] updating how modals are done --- .../js/Components/Modals/Cofnirm.vue | 20 +++----- .../js/Components/Modals/ConfirmPassword.vue | 48 ++++++++----------- .../Modals/{Dialog.vue => DialogModal.vue} | 15 ++---- src/resources/js/Components/Modals/Modal.vue | 18 ++----- 4 files changed, 35 insertions(+), 66 deletions(-) rename src/resources/js/Components/Modals/{Dialog.vue => DialogModal.vue} (82%) diff --git a/src/resources/js/Components/Modals/Cofnirm.vue b/src/resources/js/Components/Modals/Cofnirm.vue index 12b8f63..b1a2d4c 100644 --- a/src/resources/js/Components/Modals/Cofnirm.vue +++ b/src/resources/js/Components/Modals/Cofnirm.vue @@ -16,26 +16,19 @@ const props = defineProps({ }, }) -// computed properties - -// watchers - -// lifecycle hooks - // methods -function close() { +const close = (() { emit('close') -} - +}) diff --git a/src/resources/js/Components/Modals/ConfirmPassword.vue b/src/resources/js/Components/Modals/ConfirmPassword.vue index a24becb..36cf34a 100644 --- a/src/resources/js/Components/Modals/ConfirmPassword.vue +++ b/src/resources/js/Components/Modals/ConfirmPassword.vue @@ -1,5 +1,8 @@ diff --git a/src/resources/js/Components/Modals/Dialog.vue b/src/resources/js/Components/Modals/DialogModal.vue similarity index 82% rename from src/resources/js/Components/Modals/Dialog.vue rename to src/resources/js/Components/Modals/DialogModal.vue index 0493d8c..7c4c7e7 100644 --- a/src/resources/js/Components/Modals/Dialog.vue +++ b/src/resources/js/Components/Modals/DialogModal.vue @@ -16,21 +16,14 @@ const props = defineProps({ }, }) -// computed properties - -// watchers - -// lifecycle hooks - // methods -function close() { +const close = (() { emit('close') -} - +}) diff --git a/src/resources/js/Components/Modals/Modal.vue b/src/resources/js/Components/Modals/Modal.vue index 4a281d4..f9c3667 100644 --- a/src/resources/js/Components/Modals/Modal.vue +++ b/src/resources/js/Components/Modals/Modal.vue @@ -34,13 +34,6 @@ watch(() => props.show, (newShow) => { document.body.style.overflow = null } }) -/*watch(props.show, (newShow) => { - if (newShow) { - document.body.style.overflow = 'hidden' - } else { - document.body.style.overflow = null - } -})*/ // lifecycle hooks onBeforeMount(() => { @@ -53,18 +46,17 @@ onMounted(() => { }) // methods -function close() { +const close = (() => { if (props.closeable) { emit('close') } -} +}) -function closeOnEscape(e) { - if (e.key === 'Escape' && props.show) { +const closeOnEscape = ((event) => { + if (event.key === 'Escape' && props.show) { close() } -} - +})